Remove MiniAVC filters from old mod versions #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest error was a WebClient exception, which wouldn't be caused by these changes to the metadata (and may actually be GitHub throttling the script's downloads). I think it's safe to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
KSP-CKAN/NetKAN#1455 outlines the MiniAVC saga. It ends with KSP-CKAN/NetKAN#3934 removing MiniAVC filters from all .netkan files.
Problem
These filters still survive in many old .ckan files. This means that if a player spins up an old game version, they might end up with an install that doesn't conform to current CKAN policy. It's also confusing for new metadata maintainers trying to figure out what to do with MiniAVC.
An old version of TACLS
suggestsMiniAVC, even though it's no longer indexed as a standalone mod.Changes
Now all the MiniAVC filters are removed, and there are no remaining references to the aborted standalone MiniAVC module.