Can't close CKAN if not connected to the internet while refreshing mod list

[fat-lobyte]

CKAN Version:
v1.22.1-0-g174271a

Operating System:
Windows 7, 64 Bit

The issue you are experiencing:
CKAN is not closable with the "X" while the "Updating repositories" operation is running. If no internet connection is present when refreshing, sometimes this operation never finishes (not even when restoring the internet connection). Since the Cancel button is greyed out and the X-Button on the window does not react, there is no way to cleanly shutdown CKAN. You are required to kill CKAN via the task manager.

Additionally, if CKAN is then killed, the CKAN.ModuleNotFoundKraken is shown at every subsequent start, until a refresh is successful.

How to recreate this issue:

1. Start CKAN
2. Disable your computers internet connection
3. Click refresh
4. Observe that there is no way to escape CKAN now.
5. You are trapped forever.

[HebaruSan]

This happens because GUI cancels closing if the main menu is disabled:

CKAN/GUI/Main/Main.cs

Lines 435 to 442 in 2f3d817

	protected override void OnFormClosing(FormClosingEventArgs e)
	{
	// Only close the window, when the user has access to the "Exit" of the menu.
	if (!menuStrip1.Enabled)
	{
	e.Cancel = true;
	return;
	}

And it disables the main menu during registry update:

CKAN/GUI/Main/MainRepo.cs

Lines 28 to 38 in 2f3d817

	public void UpdateRepo()
	{
	tabController.RenameTab("WaitTabPage", Properties.Resources.MainRepoWaitTitle);
	try
	{
	Wait.StartWaiting(UpdateRepo, PostUpdateRepo, false, null);
	}
	catch { }
	Util.Invoke(this, SwitchEnabledState);

CKAN/GUI/Main/MainRepo.cs

Lines 45 to 48 in 2f3d817

	private void SwitchEnabledState()
	{
	_enabled = !_enabled;
	menuStrip1.Enabled = _enabled;

It also disables the main menu when you click Apply in the change set tab to start an install:

CKAN/GUI/Main/MainChangeset.cs

Lines 34 to 36 in 2f3d817

	private void Changeset_OnConfirmChanges()
	{
	menuStrip1.Enabled = false;

I would have to investigate to determine whether closing the app in these situations would cause problems. Hopefully judicious use of transactions and exception handling would at least not corrupt the registry if operations don't complete.

[HebaruSan]

This would be good to address with #1238, the user ought to be able to cancel out of updating with a broken network connection, and an unreachable repo should revert you to whatever registry you had before.