Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip licenses in spec to Debian spec #21

Closed
pjf opened this issue Oct 3, 2014 · 4 comments · Fixed by #63
Closed

Flip licenses in spec to Debian spec #21

pjf opened this issue Oct 3, 2014 · 4 comments · Fixed by #63

Comments

@pjf
Copy link
Member

pjf commented Oct 3, 2014

The debian spec does a better job of specifying all the licenses out there. We should use it, or proxy to it, for our own spec.

@pjf pjf added the design label Oct 3, 2014
@pjf pjf added this to the Usable Release milestone Oct 4, 2014
@pjf pjf added the help wanted label Oct 5, 2014
@pjf
Copy link
Member Author

pjf commented Oct 12, 2014

The debian spec doesn't distinguish between GPL2 and GPL3. I know I distinguish between them in my head, but I'm not sure if we care enough for the CKAN to care. Also, there's a lot of licenses there which nobody ever releases KSP mods under, which if nothing else means a bit more code clutter.

My expectation is that the biggest uses of the license field is if anyone wishes to make a mirror of all KSP mods, which is an obvious thing to do since a lot of mods became lost or hard to find when spaceport went down, and curse isn't exactly friendly to packaging systems.

@Wizarth
Copy link
Contributor

Wizarth commented Oct 12, 2014

It doesn't? That's an odd oversight, since they are significantly different.

@pjf
Copy link
Member Author

pjf commented Oct 12, 2014

@Wizarth : Oh! I stand corrected! Debian uses license + version, so GPL-2 and GPL-3are different. Without a number, it implies the earliest version (ie:GPLisGPL-1`).

That probably does make sense, because it means we know the version number as well, and don't need new fields whenever CC comes out with a new version of each thing.

So yes, we probably should shift to Debian-style license fields.

@pjf
Copy link
Member Author

pjf commented Oct 14, 2014

And I'm leaning back the other way on this now. The CPAN::Meta spec combines the license revision into the field itself. This makes it much easier to check using JSON schemas (which we have). The Debian version isn't JSON-schema friendly, unless we make the license number a separate field, and then we end up with a fairly complex layout:
compare:

"license" : [ { "name" => "GPL", version => "2" }, { "name" => "CC-BY", version => "3" } ]

with:

"license" : [ "GPL-2", "CC-BY-3" ]

Although we're possibly fine by using the Debian strings and enumerating all the different license versions in the schema. So GPL-1, GPL-2 and GPL-3 would all validate, but GPL-4 and GPL-3-with-some-clause-removed would not.

pjf added a commit to pjf/CKAN that referenced this issue Oct 14, 2014
With some minor tweaks to remain sane.

Closes KSP-CKAN#21.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants