Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetKAN AVC support for split distributions #269

Closed
KevinCathcart opened this issue Nov 6, 2014 · 3 comments
Closed

NetKAN AVC support for split distributions #269

KevinCathcart opened this issue Nov 6, 2014 · 3 comments
Labels
Netkan Issues affecting the netkan data

Comments

@KevinCathcart
Copy link

When a single distribution is split into multiple packages (like is sometimes done for configs, or to separate out optional parts), and the original distribution contains only one .version file, only the package that will include that version file can use it to set the KSP version information.

It would be nice if there were some way for all the packages from that single distribution to use that single version file.
@pjf
Copy link
Member

pjf commented Nov 6, 2014

I agree. I'd really love a #/ckan/ksp-avc/RootPackage or similar. Alternatively, and probably more portably, we could have #/ckan/ksp-avc/path/to/internal/file.version. The downside is that packages that change their directory structure (common with source releases from git, which prepend the repo and version) won't work with this.

@pjf pjf added the Netkan Issues affecting the netkan data label Nov 6, 2014
@pjf pjf mentioned this issue Nov 6, 2014
Open
@pjf pjf added the ★★☆ label Nov 7, 2014
@pjf
Copy link
Member

pjf commented Nov 10, 2014

Kevin: I'm looking at a partial implementation whereby if we can't find a .version file in the list of files we'd install, we then go to check to see if there's only a single .version file in the archive, and use that if there is.

It's not as ideal as a full implementation, but it'll cover many of the common cases where version checks are being performed. (And should definitely help with RPM.)

pjf added a commit to pjf/CKAN that referenced this issue Nov 10, 2014
@pjf
NetKAN: Search more aggressively for .version files.
dcfed64 
Previously, we'd only use a `.version` file if it was going to be
installed.

Now, we'll still check the installed files first, but will fall back
to using a lone `.version` file if it's the only one in the archive.

Eases KSP-CKAN#269.
This was referenced Nov 10, 2014
Merged
Merged
@AlexanderDzhoganov AlexanderDzhoganov mentioned this issue Nov 21, 2014
Closed
10 tasks
@Ippo343
Copy link
Contributor

Ippo343 commented Dec 27, 2014

This issue was moved to KSP-CKAN/CKAN-netkan#10

@Ippo343 Ippo343 closed this as completed Dec 27, 2014
@Ippo343 Ippo343 removed the ★★☆ label Dec 27, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
NetKAN: Search more aggressively for .version files.
540bc56 
Previously, we'd only use a `.version` file if it was going to be
installed.

Now, we'll still check the installed files first, but will fall back
to using a lone `.version` file if it's the only one in the archive.

Eases KSP-CKAN#269.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Netkan Issues affecting the netkan data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjf @KevinCathcart @Ippo343