Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KerbalStuff Transformer #1305

Merged
merged 1 commit into from
Jul 17, 2015
Merged

Conversation

dbent
Copy link
Member

@dbent dbent commented Jul 16, 2015

This makes a few small changes to the KerbalstuffTransformer:

  • Licenses we receive from KS are trimmed, I've seen a couple of cases of otherwise valid license strings being rejected because they had leading or trailing whitespace.
  • The specific cases of GPLv2 and GPLv3 are transformed into CKAN compatible license strings, since those are two of the default options for licenses on KS.
  • The x_screenshot property is moved from being a top-level property to a child of resources, which I think makes more sense.

@dbent
Copy link
Member Author

dbent commented Jul 16, 2015

@plague006 I think that comment was meant for #1304? Done in 23dbb4a.

@mheguy
Copy link
Contributor

mheguy commented Jul 16, 2015

Yes it was. Deleted my comment because it's off-topic.

RichardLake added a commit that referenced this pull request Jul 17, 2015
@RichardLake RichardLake merged commit dfe7cbd into master Jul 17, 2015
@mheguy mheguy deleted the topic/update_ks_transformer branch July 17, 2015 12:31
@mheguy mheguy restored the topic/update_ks_transformer branch July 17, 2015 12:31
@mheguy mheguy deleted the topic/update_ks_transformer branch July 17, 2015 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants