Fix issue where CKAN would crash after installing mods if you are sorting by KSP version.

[Antialiased]

This was related to mods with ksp_version 'any' in JSON, which is handled differently to mods with no ksp_version field, and the UI code was not knowledgeable about the difference

[ayan4m1]

I can reproduce this on Win10x64, CKAN 1.18.1, sort by "Max KSP Version," select one or more mods with "Any version" as their version string, click Install, after install completes the exception is thrown. The app still works but the DataGrid is unresponsive or throws more exceptions.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at CKAN.Main.DefaultSorter(DataGridViewRow row)
   at System.Linq.EnumerableSorter`2.ComputeKeys(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.Sort(TElement[] elements, Int32 count)
   at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__1.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at CKAN.Main._UpdateFilters()
   at CKAN.Util.Invoke[T](T obj, Action action)
   at CKAN.Main._UpdateModsList(Boolean repo_updated)
   at CKAN.Util.Invoke[T](T obj, Action action)
   at CKAN.Main.PostInstallMods(Object sender, RunWorkerCompletedEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)

[politas]

@ayan4m1, can you slap a "merge pending" label on this if you think it's good? It looks fine to me, without any way currently to test it.

[ayan4m1]

I'm working on the proper UI-side fixes for the NRE itself, but I don't think we should be changing any code in the Core module if we can avoid it.

[Darbbo]

Still getting this crash:

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at CKAN.Main.DefaultSorter(DataGridViewRow row)
   at System.Linq.EnumerableSorter`2.ComputeKeys(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.Sort(TElement[] elements, Int32 count)
   at System.Linq.OrderedEnumerable`1.<GetEnumerator>d__1.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at CKAN.Main._UpdateFilters()
   at CKAN.Util.Invoke[T](T obj, Action action)
   at CKAN.Main._UpdateModsList(Boolean repo_updated)
   at CKAN.Util.Invoke[T](T obj, Action action)
   at CKAN.Main.PostInstallMods(Object sender, RunWorkerCompletedEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)

[politas]

A new release will be out soon that fixes it, but we have another bug that needs to be squashed before we can release.

[Darbbo]

Awesome thank you for the quick response. I will await the fix patiently then.

On Saturday, September 3, 2016 12:18 AM, Myk <notifications@github.com> wrote:

A new release will be out soon that fixes it, but we have another bug that needs to be squashed before we can release.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[politas]

@Darbbo, can you test this with CKAN 1.20.0 Yuri? The fix should be there.