WIP: Handle InconsistentKraken from RelationshipResolver in GUI #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curently failing test/GUI/MainModList.cs/ComputeChangeSetFromModList_WithConflictingMods_ThrowsInconsistentKraken My C# skills have failed me, and I need to work out what's happening. |
|
I keep getting this: I don't know whether this test needs to change? If we're handling the InconsistentKraken exception, is it no longer thrown? |
|
The new RaiseError is throwing three error dialogs for some reason. But at least it is now throwing errors! |
politas
force-pushed
the
fix/1864-CatchInconsistentKrakenInGUI
branch
from
e89bfc3
to
e28f295
Compare
|
@politas If you can resolve the conflicts I think this would be a good PR to merge in. What is WIP about it? |
|
That it isn't working properly. |
politas
force-pushed
the
fix/1864-CatchInconsistentKrakenInGUI
branch
from
e28f295
to
7451fc0
Compare
|
Ok, rebased, at least |
Merged
|
This branch is all types of messed up. I'm starting afresh. |
|
This seems to be the afresh branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally tracked down the cause of the weirdness. Now to fix it!
Closes #1864