Revert "Merge #1929 Allow uninstall of incompatible mods in GUI" #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayan4m1, There's a bug that crept in with your #1929 PR. When a mod is selected that triggers a dependency choice, the dialog pops up, the user selects an option, and the selected option appears to be checked for install in the modlist, but it doesn't appear to be fully chosen. Applying changes throws a "TooManyModsProvideKraken" (#1274) and selecting other changes causes the Provides selection box to reappear, over and over. The selected provider does appear in the changelist, though. It's very odd. |
politas
added a commit
that referenced
this pull request
Oct 17, 2017
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 85d72b6, reversing
changes made to bcf87c2.