Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Update #2158

Merged
merged 17 commits into from
Oct 23, 2017
Merged

Build Update #2158

merged 17 commits into from
Oct 23, 2017

Conversation

dbent
Copy link
Member

@dbent dbent commented Oct 21, 2017

General update to the build. Important new feature: The csproj files have been updated to generate the GlobalAssemblyVersionInfo file if it doesn't already exist. This should allow the project to build out-of-the-box in IDEs like Visual Studio without having to go to the command line first.

Other updates:

  • Add Release and Debug targets
  • Remove unused variable to fix warning
  • Update Mono versions used for build
    • Remove Mono 4.0.5 (breaking with newest Cake)
    • Upgrade Mono 4.8.0 to 4.8.1
    • Upgrade Mono 5.0.0 to 5.0.1
    • Add Mono 5.2.0
    • Add Mono 5.4.0
  • Upgrade NuGet from 4.1.0 to 4.4.0 (and use restore instead of install)
  • Upgrade Cake from 0.19.5 to 0.23.0 (and fix new breaks script)
  • Upgrade Cake.SemVer from 1.0.14 to 2.0.0
  • Upgrade NUnit.ConsoleRunner from 3.6.1 to 3.7.0
  • Upgrade JSON.NET from 10.0.2 to 10.0.3
  • Upgrade Autofac from 4.5.0 to 4.6.2
  • Upgrade Castle.Core from 4.0.0 to 4.2.1
  • Upgrade Moq from 4.7.10 to 4.7.142
  • Upgrade NUnit from 3.6.1 to 3.8.1

@dbent dbent added the In progress We're still working on this label Oct 21, 2017
@dbent dbent self-assigned this Oct 21, 2017
@dbent dbent removed the In progress We're still working on this label Oct 21, 2017
@politas
Copy link
Member

politas commented Oct 22, 2017

How about changing from xbuild to msbuild to get rid of those warnings? Ah, never mind - asked and answered already under #2048


Task("Release")
.IsDependentOn("Default");

Task("Ckan")
Copy link
Member

@politas politas Oct 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make these task names case-agnostic?
Or maybe they already are, and there's a different issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They already are.

@politas
Copy link
Member

politas commented Oct 22, 2017

When attempting ./build Release I get:

Error: One or more errors occurred.
	Argument 'configuration' was not set.

And I get the same if I just ./build

./build --configuration=Release works fine as before

@Olympic1
Copy link
Member

Getting the same error as @politas

build.cake Outdated
@@ -157,6 +165,26 @@ Task("Version")
Information(GetVersion().ToString());
});

Setup(context =>
{
var argConfiguration = Argument<string>("configuration");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding , "Debug" after "configuration" fixes this for me.

@dbent
Copy link
Member Author

dbent commented Oct 22, 2017

Build without explicit configuration argument fixed.

@politas politas merged commit be255a8 into master Oct 23, 2017
politas added a commit that referenced this pull request Oct 23, 2017
@politas
Copy link
Member

politas commented Oct 23, 2017

All seems to work, now.

@politas politas deleted the feature/build_update branch October 23, 2017 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants