Cleanup project #2182
Cleanup project #2182
Conversation
Olympic1
added
Architecture
Build
|
I'll check and make a PR on you repo is it needs some changes |
Update to MSBuildToolsPath Update builds Format App.config Fix included version files Cleanup last bits in project files
|
Cleaned up last bits and updated some nuget packages. |
|
Do you want another reviewer to take a look? I'd be fine with merging this, but I don't want to short-circuit the review process if that's not how things are supposed to be done. |
|
I definitely want someone to review the powershell build script before merging this. |
build.ps1
Outdated
| $CakeVersion = (Select-Xml -Xml ([xml](Get-Content $PackagesConfigFile)) -XPath "//package[@id='Cake'][1]/@version").Node.Value | ||
| $CakeExe = "${PackagesDir}/Cake.${CakeVersion}/Cake.exe" | ||
| $CakeExe = "${PackagesDir}\Cake.${CakeVersion}\Cake.exe" | ||
|
|
There was a problem hiding this comment.
Since Windows is fine with the forward slashes, but Linux treats them as escape characters, it makes sense to me to use forward slashes to make the two build scripts easy to keep in sync. Is there a particular reason to switch to backslashes other than "that's how Windows users see paths?"
There was a problem hiding this comment.
Yeah, this change isn't really necessary as both forward- and backslashes are valid path separators on Windows.
|
Reverted the slashes in the build script. Unless someone wants some more changes, this is ready to merge. |
Cleaned up the repo by removing unused references. Also fixed the paths in the powershell build script.
I need some feedback on the powershell build script.
Changes:
.gitattributesand.gitignorefiles, so we use the global ones.gitattributesApp.config'sToolsVersionto 15.0MSBuildToolsPath, asMSBuildBinPathwas deprecatedInclude's alphabeticallyLICENSEtoLICENSE.mdlog4netNewtonsoft.JsonMicrosoft.CSharpCommandLineParserto 1.9.71.2 (now uses .NET 4.5)TxFileManagerto use .NET 4.5SharpZipLibto 0.86.5.1CommandLineChinhDo.Transactions.FileManagerSystem.*referencesMicrosoft.CSharpSystem.*referencesuserInstalledtag, as this was deprecated 2 years agoSharpZipLibto 0.86.5.1SharpZipLibto 0.86.5.1Moqto 4.7.145NUnitto 3.9.0System.Configuration.versionfiles