Only check first three segments of version in ci (fixes #2191) #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Build
|
Awesome, basically it's just ensuring we push up only one artifact by the looks. That should get the job, thanks for your awesome work @HebaruSan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment on #2191; the
mono --versioncheck is now printing 5.4.0.201 instead of just 5.4.0, and our perl regex extracts that whole string. This pull request changes the perl regex to match just the 5.4.0 part, so it should match BUILD_RELEASE_MONO_VERSION again.This should get builds deploying to S3 again, which should fix the Curse errors on the status page.