Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and release CKAN.app for Mac OS X #2225

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Dec 16, 2017

Mac support is a bit spotty currently, with users resorting to launching the GUI from Terminal.app, and user-created CKAN.app package running GUI from Terminal.app via AppleScript.

This pull request adds a CKAN.app download to releases, generated in the style of #2187.

Advantages over the user-created package:

  • Contains ckan.exe internally rather than a separate download
    • Avoids problems associated with finding ckan.exe, such as quoting spaces in paths
  • Terminal.app not required
  • Uses standard icon from assets folder

Manual separate installation of Mono is still required.

TESTING REQUIRED, I DO NOT HAVE A MAC!

Sample build for testing:

Fixes #1989.

@HebaruSan HebaruSan added Build Issues affecting the build system Cake Issues affecting Cake Enhancement New features or functionality macOS Issues specific for macOS labels Dec 16, 2017
@politas
Copy link
Member

politas commented Dec 17, 2017

One for @KSP-CKAN/macos-testers to have a look at

@jwwolff
Copy link

jwwolff commented Dec 19, 2017

So I tested it and it won't launch(gives the error "the application 'CKAN' can't be opened). My guess is your creation of the .app didn't work correctly.

@HebaruSan
Copy link
Member Author

Thanks, @jwwolff !
I think that means the launch script isn't executable, which I probably should have thought of before now.
I've updated the download. Could you please try it again?

@jwwolff
Copy link

jwwolff commented Dec 19, 2017

Still doesn't work. Same error.

@jwwolff
Copy link

jwwolff commented Dec 19, 2017

(I suggest using a program called platypus if you can't figure out the problem. It might help)
p.s. thanks for doing this it'd be super nice to have a .app for Mac users

@HebaruSan
Copy link
Member Author

Well luckily this time the error was simple: the new zip was the same as the old zip. I've updated the download again so at least this time you can test the change I meant to make.

@HebaruSan HebaruSan force-pushed the feature/mac-app branch 2 times, most recently from de4b33b to ab311b1 Compare December 19, 2017 18:51
@jwwolff
Copy link

jwwolff commented Dec 20, 2017

So good news and bad news. Good news, the app is openable and the executable inside the app does launch ckan when launched manually from terminal but bad news the app when opened just leads to the installing ckan on OSX web page. (And yes I do have mono installed)

@HebaruSan
Copy link
Member Author

HebaruSan commented Dec 20, 2017

OK, that's what it's supposed to do if it can't find mono.

If you open a terminal on your system and run "which mono", does it print the correct location?
Assuming the answer is 'no', what about "mdfind mono"?

@ProfFan
Copy link
Member

ProfFan commented Dec 20, 2017

Probably it should find mono in its launch script. Then you can set the environment variables for finding mono.

@politas
Copy link
Member

politas commented Dec 20, 2017

Ok, now I'm confused - @jwwolf made a new release as mentioned in this forum post - Is that what we have here, or an is it an improved version?

@HebaruSan
Copy link
Member Author

This is different from jwwolff's. jwwolff has created one download manually containing one version of ckan.exe, on a repo not owned by KSP-CKAN. This pull request automates the process and adds the new downloads to the main asset list of the releases, so each new version of ckan.exe would be available for Mac.

@ProfFan , it is trying to find mono in the launch script, unless I'm not understanding what you mean by that. Are you saying there are environment variables that will take care of that for us? That would be excellent, any knowledge you can provide on that would be very much appreciated!

@politas
Copy link
Member

politas commented Dec 21, 2017

Sorry, I wasn't clear, what I should have said is, does this create a .app file that has all the features @jwwolff has put in his?

@HebaruSan
Copy link
Member Author

HebaruSan commented Dec 21, 2017

Ahh, I see. Let me go through his list from that post...

  • doesn't use automator
  • fixes space handling in the path
  • doesn't require a separate download of ckan.exe
  • works like any normal Mac app does

Yes, I think we're at feature parity.

@politas
Copy link
Member

politas commented Dec 21, 2017

Now I'm wondering whether we should add a Windows installer as well!

@politas politas merged commit a4774d8 into KSP-CKAN:master Dec 21, 2017
politas added a commit that referenced this pull request Dec 21, 2017
@HebaruSan HebaruSan deleted the feature/mac-app branch December 21, 2017 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues affecting the build system Cake Issues affecting Cake Enhancement New features or functionality macOS Issues specific for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants