-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and release CKAN.app for Mac OS X #2225
Conversation
One for @KSP-CKAN/macos-testers to have a look at |
ccbc247
to
0cd717a
Compare
So I tested it and it won't launch(gives the error "the application 'CKAN' can't be opened). My guess is your creation of the .app didn't work correctly. |
Thanks, @jwwolff ! |
0cd717a
to
b153659
Compare
Still doesn't work. Same error. |
(I suggest using a program called platypus if you can't figure out the problem. It might help) |
Well luckily this time the error was simple: the new zip was the same as the old zip. I've updated the download again so at least this time you can test the change I meant to make. |
de4b33b
to
ab311b1
Compare
So good news and bad news. Good news, the app is openable and the executable inside the app does launch ckan when launched manually from terminal but bad news the app when opened just leads to the installing ckan on OSX web page. (And yes I do have mono installed) |
OK, that's what it's supposed to do if it can't find mono. If you open a terminal on your system and run "which mono", does it print the correct location? |
ab311b1
to
a4774d8
Compare
Probably it should find mono in its launch script. Then you can set the environment variables for finding mono. |
Ok, now I'm confused - @jwwolf made a new release as mentioned in this forum post - Is that what we have here, or an is it an improved version? |
This is different from jwwolff's. jwwolff has created one download manually containing one version of ckan.exe, on a repo not owned by KSP-CKAN. This pull request automates the process and adds the new downloads to the main asset list of the releases, so each new version of ckan.exe would be available for Mac. @ProfFan , it is trying to find mono in the launch script, unless I'm not understanding what you mean by that. Are you saying there are environment variables that will take care of that for us? That would be excellent, any knowledge you can provide on that would be very much appreciated! |
Sorry, I wasn't clear, what I should have said is, does this create a .app file that has all the features @jwwolff has put in his? |
Ahh, I see. Let me go through his list from that post...
Yes, I think we're at feature parity. |
Now I'm wondering whether we should add a Windows installer as well! |
Mac support is a bit spotty currently, with users resorting to launching the GUI from Terminal.app, and user-created CKAN.app package running GUI from Terminal.app via AppleScript.
This pull request adds a CKAN.app download to releases, generated in the style of #2187.
Advantages over the user-created package:
Manual separate installation of Mono is still required.
TESTING REQUIRED, I DO NOT HAVE A MAC!
Sample build for testing:
Fixes #1989.