Show status bar text, add progress bar #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Olympic1
requested changes
Jan 9, 2018
| @@ -124,7 +124,6 @@ private void InitializeComponent() | |||
| this.splitContainer1.SuspendLayout(); | |||
| ((System.ComponentModel.ISupportInitialize)(this.ModList)).BeginInit(); | |||
| this.ModListContextMenuStrip.SuspendLayout(); | |||
| this.StatusPanel.SuspendLayout(); | |||
There was a problem hiding this comment.
Add this.statusStrip1.SuspendLayout();
| @@ -1054,7 +1048,6 @@ private void InitializeComponent() | |||
| this.splitContainer1.ResumeLayout(false); | |||
| ((System.ComponentModel.ISupportInitialize)(this.ModList)).EndInit(); | |||
| this.ModListContextMenuStrip.ResumeLayout(false); | |||
| this.StatusPanel.ResumeLayout(false); | |||
There was a problem hiding this comment.
Add
this.statusStrip1.ResumeLayout(false);
this.statusStrip1.PerformLayout();
| this.StatusProgress.Minimum = 0; | ||
| this.StatusProgress.Maximum = 100; | ||
| this.StatusProgress.Size = new System.Drawing.Size(300, 20); | ||
| this.StatusProgress.Alignment = System.Windows.Forms.ToolStripItemAlignment.Right; |
There was a problem hiding this comment.
Add this.StatusProgress.Name = "StatusProgress";
GUI/Main.Designer.cs
Outdated
| this.StatusLabel.Name = "StatusLabel"; | ||
| this.StatusLabel.Size = new System.Drawing.Size(1050, 29); |
GUI/Main.Designer.cs
Outdated
| this.statusStrip1.Name = "statusStrip1"; | ||
| this.statusStrip1.Padding = new System.Windows.Forms.Padding(2, 0, 21, 0); | ||
| this.statusStrip1.Size = new System.Drawing.Size(1544, 22); |
| // statusStrip1 | ||
| // | ||
| this.statusStrip1.ImageScalingSize = new System.Drawing.Size(24, 24); | ||
| this.statusStrip1.Location = new System.Drawing.Point(0, 1016); |
There was a problem hiding this comment.
Oh, the IDE probably needs that stuff for the graphical editor, doesn't it? OK...
Olympic1
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
CKAN's GUI has a status bar that is always empty:
And some code that tries to set it:
CKAN/GUI/MainDialogs.cs
Lines 23 to 27 in 378d128
Currently they aren't connected.
Causes
Two different status bar controls are in use at the moment: the one that is visible, and the one that receives the status messages from code.
statusStrip1is the control that's actually visible. It has no contained controls and none of its properties are set by code during downloads/installs.StatusPanelis a panel which is technically added to the form but not visible.StatusLabelis a label which is added to this and which receives the status messages from the application, but again is not visible.Changes
The status bar code is rewritten according to the documentation for StatusStrip.
StatusPanelis removedStatusLabelis changed to typeSystem.Windows.Forms.ToolStripStatusLabeland added tostatuStrip1insteadToolStripProgressBarcontrol is added to mirror the behavior of the progress bar on the install screenTogether, these changes make the status bar work as intended: