Don't double encode GitHub download URLs #2402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Netkan currently is double-encoding GitHub download URLs, which causes any URL that has an encoded character to fail. See #2401 for details.
Cause
The GitHub API returns the URL already encoded:
We then encode it again, which changes any
%
characters to%25
, which makes the URL fail with a 404 status:CKAN/Netkan/Transformers/GithubTransformer.cs
Line 78 in a495f43
Changes
The
Uri.EscapeUriString
call is removed. The DestructionEffects netkan succeeds with this change.Fixes #2401.