Add Install Date column to GUI mod list #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
GUI
HebaruSan
force-pushed
the
feature/inst-date-col
branch
from
bd4d4ca
to
143bc40
Compare
:100644 100644 461847e9 407319cb M GUI/GUIMod.cs :100644 100644 9dccb6d6 2e538722 M GUI/Main.Designer.cs :100644 100644 f8bd12ec a01f4134 M GUI/MainModList.cs :100644 100644 461847e9 43bd6146 M GUI/GUIMod.cs :100644 100644 9dccb6d6 2e538722 M GUI/Main.Designer.cs :100644 100644 f8bd12ec a01f4134 M GUI/MainModList.cs
HebaruSan
force-pushed
the
feature/inst-date-col
branch
from
143bc40
to
ff0142f
Compare
politas
added a commit
that referenced
this pull request
Aug 23, 2018
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CKAN tracks the date and time when a mod was installed, but this information is not shown in GUI. It could be useful to be able to sort installed mods so you can see the order in which they were installed.
Changes
Now a new sortable Install Date column shows when mods were installed:
To achieve this, you can now construct a
GUIModobject from anInstalledModule, or aCkanModule, or astringidentifier. The constructors are layered by: this()calls so the simplest initialization is done first, then supplemented by whatever additional info is at hand. TheInstalledModule-based constructor populates a newInstallDateproperty.MainModList._UpdateModsListis updated to generateGUIModobjects based onInstalledModuleobjects when they are available.The logic for making one row of the mod list is now split out from
MainModList.ConstructModListinto a new privateMakeRowfunction.Fixes #954. Fixes #1046. Fixes #1933.