Fix null ref exception when repo has empty ckan file #2549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you refresh the registry and the remote repo contains an empty .ckan file, you may see exceptions with stack traces like these:
Causes
An empty file would cause the first line here to return null:
CKAN/Core/Net/Repo.cs
Lines 550 to 551 in b9a91fa
If that happens, then the second line still tries to access a property on the null reference.
Changes
Now we skip that debug output if the reference is null.
Fixes #1381.