Show latest updates after refresh

[HebaruSan]

Problem

After you click Refresh in GUI, the latest updates are downloaded from the repo, but only certain changes are reflected in the mod list:

• Newly added mods
• New versions
• Installation status

But if other things change, this isn't shown in the mod list until you restart CKAN:

• Game version compatibility
• Display name or abstract
• Author
• Download size or count
• Etc.

Cause

ConstructModList goes out of its way to cause this problem in order to avoid losing user changes. A refreshAll parameter is passed based on whether we're doing a repo update, in which case the previous GUIMod objects are mostly kept. This is kind of odd because a repo update is the only way that most of those properties can be changed.

CKAN/GUI/MainModList.cs

Lines 198 to 199 in b9a91fa

	// Update our mod listing. If we're doing a repo update, then we don't refresh
	// all (in case the user has selected changes they wish to apply).

CKAN/GUI/MainModList.cs

Line 682 in b9a91fa

/// <param name="refreshAll">If set to <c>true</c> then always rebuild the list from scratch</param>

CKAN/GUI/MainModList.cs

Lines 692 to 697 in b9a91fa

	// We're only going to update the status of rows that either don't already exist,
	// or which exist but have changed their latest version
	// or whose installation status has changed
	//
	// TODO: Will this catch a mod where the latest version number remains the same, but
	// another part of the metadata (eg: dependencies or description) has changed?

(The answer to that final question is, "No.")

Changes

Now the GUIMod objects built by UpdateModsList will have .IsInstallChecked and .IsUpgradeChecked set to match the change set parameter, and the Refresh button passes the current change set in that parameter. This ensures that the new GUIMod objects will not lose the change set when refreshing.

Then ConstructModList just unconditionally generates new rows for everything, since it can trust that their checkbox values are reflected in the GUIMod objects. The refreshAll parameter is removed as it is no longer needed.

Together, these changes mean that if you select several mods to install and click Refresh, then those same mods will still be checked afterwards, and all rows will show the latest info, even the ones you checked.

Fixes #1738.