Don't show status progress bar till actually installing #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Olympic1
added a commit
that referenced
this pull request
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you choose to install a mod that has recommendations or suggestions, the status-bar progress bar will appear while the recommendation and suggestion lists are visible.
If you then cancel out of these screens, that progress bar will remain visible on the main mod list, effectively stuck there until you start and complete another installation.
Cause
This progress bar is shown and hidden in the
ShowWaitDialogandHideWaitDialogfunctions that initialize and reset the log tab and its progress bar, respectively.ShowWaitDialogis called too early in the install process, before recommendations and suggestions are handled. We don't need it yet at that point, so the tab sits uselessly in the background while the user deals with recommendations and suggestions, and the status bar shows a progress bar when it shouldn't.Changes
Now we don't call
ShowWaitDialoguntil after recommendations and suggestions are handled, when we're ready to do the actual installation. This will leave the progress bar hidden until it's needed. It also simplifies the clean-up a bit when the user cancels.Fixes #2417.
Closes #2418. (Addressing the same issue, somewhat more complexly, but now has conflicts with master and hard to tell what the changes were.)