Encapsulate usages of WebClient #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Pull request
Netkan
politas
added a commit
that referenced
this pull request
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have some network problems that hypothetically might be helped by transitioning from
WebClientto some other library for network access (e.g., #2546), but currentlyWebClientcode is spread through several places in the code, making it difficult to refactor cleanly.Changes
The Netkan source
GitHubApinow accepts anIHttpServiceparameter as the other Netkan sources do and uses it to access the GitHub API instead of making its ownWebClient. This allows tests of this class to "mock" network accesses (though no test does this yet).All other places that were previously using
WebClientdirectly now call one of two central access points:Net.DownloadTextorNetAsyncDownloader. This will make it easier to transition all of this code to some other underlying library in the future if needed.