Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of recently (probably #2613),
./build test
is failing on Mono for me with this:Cause
All of these tests instantiate a
NetFileCache
orNetModuleCache
member variable in a setup step, and in the teardown step they just delete the cache directory. For example:CKAN/Tests/NetKAN/Sources/Curse/CurseApiTests.cs
Lines 18 to 32 in f98b9f0
However, this is not enough to clean up after a cache object.
NetFileCache
inherits fromIDisposable
and uses itsDispose
method to dispose theFileSystemWatcher
object that is mentioned so many times in the above errors:CKAN/Core/Net/NetFileCache.cs
Lines 79 to 92 in f98b9f0
Apparently we finally have enough cache objects being created to run into problems with not disposing them.
Changes
Now we dispose the cache objects we create for tests in the teardown functions. This fixes the above errors for me.