Allow overriding menu tip in ConsoleUI #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
Closed
|
Nice 👍 |
|
Note that we reserve the right to change it back to Menu if we ever need to add non-link content to that menu. :) |
|
I am willing to make this comprise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The screen tip for the main menu is always "F10 - Menu" in ConsoleUI, but sometimes a more specific string might be helpful.
Changes
Now the "F10 - Menu" tip is changed on two screens:
As a bit of side cleanup,
ConsoleScreen.LeftHeaderandConsoleScreen.CenterHeaderare now changed fromFunc<string>variables to virtual string functions (to be consistent with the newly addedMenuTip). This is a cleaner way of providing a function that can be overridden in a child class.