Derive User classes directly from IUser interface instead of the NullUser class. #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of the NullUser class. Remove the unnecessary `Display...()` methods. Still needs `RaiseSelectionDialog()` implementation for the GUI. Coming soon...
|
Added the GUI dialog, looks like this: " -- Default" is added to the default selection, if any. |
DasSkelett
changed the title
HebaruSan
reviewed
Jan 11, 2019
HebaruSan
added
GUI
Used right now to find out whether to show confirmation dialogs prior to mod changes.
Also adjusted the .csproj for the new SelectionDialog form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Our UI specific
(I)Userclasses for interacting with the... user are pretty messy.Besides to the consoleUI all of them are inheriting from
NullUserinstead of directly extending theIUserinterface, which kinda misses the point of having an interface.Also the
NullUserimplements aDisplay...()method for eachIUsermethod on top of the existingRaise...()methods, just to let theRaise..()ones call theDisplay...()ones without any reason to do so.Solution:
Now all
Userclasses inherit directly fromIUser.NullUseris now only used in tests.All
Display...()methods are removed.Added LOTS of code documentation, because I could have needed them...
And i implemented the selection dialog for the GUI.