Don't try to update filters if mod list missing #2654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since #2617, we occasionally get exceptions at startup:
Cause
Now that
UpdateModsList
runs in a background thread, things that formerly happened afterwards can now run alongside it, including several places that populate the mod filters in the GUI. This callsUpdateFilters
, which crashes here ifUpdateModsList
hasn't setmainModList.full_list_of_mod_rows
yet:CKAN/GUI/MainModList.cs
Line 109 in 1bbd2fd
Changes
Now
UpdateFilters
treats the existence ofmainModList.full_list_of_mod_rows
as a prerequisite and quits if it's null.Fixes #2650.