Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small text/number formatting changes to mod list #2658

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Small text/number formatting changes to mod list #2658

merged 1 commit into from
Jan 14, 2019

Conversation

DasSkelett
Copy link
Member

  • Align the download count number to the right
  • Align the size text to the right
  • Format the download count number with thousands separators.
  • Change size appendages to binary prefixes following ISO/IEC 80000-13:2008 and IEEE 1541-2002 ;)

@DasSkelett
Small text/number formatting changes to mod list
fd85673 
* Align the download count column number to the right
* Align the size column text to the right
* Format the download count number with culture-dependent thousands separators.
* Change size appendends to binary prefixes
@politas
Copy link
Member

politas commented Jan 14, 2019

You can bet that some people will complain about the KiB/MiB/GiB change.

@politas politas merged commit fd85673 into KSP-CKAN:master Jan 14, 2019
politas added a commit that referenced this pull request Jan 14, 2019
@politas
Merge #2658 Small text/number formatting changes to mod list
9729b75
@HebaruSan
Copy link
Member

... starting with me. Is that necessary? It seems like pedantry for its own sake.

@DasSkelett DasSkelett deleted the fix/downloadsCountFormat branch January 14, 2019 10:19
@DasSkelett
Copy link
Member Author

No, not necessary. But I think more correct.
So why don't do it this way?
It's not as if this was a big effort to change.

@HebaruSan
Copy link
Member

Basically because no one uses those abbreviations, and everyone uses MB and GB.

@DasSkelett
Copy link
Member Author

So make the people use them ; )

@HebaruSan
Copy link
Member

Well, at least 'i' is a small character. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DasSkelett @politas @HebaruSan