Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle manually installed mods in ConsoleUI #2666

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

HebaruSan
Copy link
Member

Problems

Manually installed mods (or "auto detected" or "AD") are not handled well in ConsoleUI.

  • They're shown as simply installed (check mark symbol)
  • You can try to uninstall them
  • The mod info screen crashes if you try to view them

Causes

I tend not to use AD mods, so I didn't test it in ConsoleUI.
Now I have some symlinks set up for the dev versions of my mods, so I stumbled across this.

Changes

  • AD mods now have their own status symbol in the mod list: infinity
    • Added to the help screen
  • The key tip and hotkey for uninstallation are disabled for AD mods
  • The mod info screen now doesn't crash and shows AD mods with a "Installed manually" header and "???" for the version and game version compatibility
  • Several occurrences of "identifer" in the code are corrected to "identifier".

image

image

image

@HebaruSan HebaruSan added Bug Pull request ConsoleUI Issues affecting the interactive console UI labels Jan 24, 2019
@politas politas merged commit 69a8ff7 into KSP-CKAN:master Jan 27, 2019
@HebaruSan HebaruSan deleted the fix/ad-consoleui branch January 27, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug ConsoleUI Issues affecting the interactive console UI Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants