Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort AD above empty checkboxes #2691

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

HebaruSan
Copy link
Member

Problem

If you have manually installed mods, the Inst column shows up as "AD" for them. If you sort by the Inst checkbox column, AD mods appear at the very end of the list, far away from the CKAN-installed mods represented by a checked box.

And the "AD" and "-" strings are left aligned while the checkboxes are centered, which doesn't look great.

image

Changes

Now the sort goes:

  1. CKAN-installed mods (checked checkboxes)
  2. AD mods
  3. Non-installed compatible mods (unchecked checkboxes)
  4. Incompatible mods ("-")

Also the checkbox columns are centered now so the "-" aligns better with the checkboxes.

image

@HebaruSan HebaruSan added Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Mar 4, 2019
@politas politas merged commit 4875f1e into KSP-CKAN:master Mar 21, 2019
politas added a commit that referenced this pull request Mar 21, 2019
@HebaruSan HebaruSan deleted the fix/sort-ad branch March 21, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants