Prevent Null entry in CompatibleKSPVersions #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DasSkelett, could you review this? |
politas
added
Bug
Easy
|
Looks good to me! |
DasSkelett
approved these changes
Mar 29, 2019
politas
added a commit
that referenced
this pull request
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKAN treats a null KSP version in a modversion as "Any", so that a .ckan file with no version information does what we would expect.
The CompatibleKSPVersions dialog allows users to add arbitrary version strings, and then uses the same KSP version parsing that we use for calculating modversion compatibility. This results in a null return value for the text string "any", which does not get caught as an invalid string, allowing the JSON file to be saved with a entry in the CompatibleVersionsList.
On next launch of CKAN, the null entry causes an error.
Now, attempts to add the string "any" to the CompatibleKSPVersionsList are captured and prevented.
Closes #2705