Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size of relationships list #2728

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Apr 13, 2019

Problem

The relationships tree doesn't fit in the available space:

image

Cause

#2592 moved the top of the tree control down 92 pixels without changing its height, so the bottom slid down as well, past the bottom of the available space. The parent control starts at 502 pixels tall, while the tree's top is 96 and height is 489, so the bottom is at 96+489 =585:

this.RelationshipTabPage.Size = new System.Drawing.Size(354, 502);
this.RelationshipTabPage.TabIndex = 1;
this.RelationshipTabPage.Text = "Relationships";
this.RelationshipTabPage.UseVisualStyleBackColor = true;
//
// DependsGraphTree
//
this.DependsGraphTree.Anchor = ((System.Windows.Forms.AnchorStyles)((((System.Windows.Forms.AnchorStyles.Top | System.Windows.Forms.AnchorStyles.Bottom)
| System.Windows.Forms.AnchorStyles.Left)
| System.Windows.Forms.AnchorStyles.Right)));
this.DependsGraphTree.BorderStyle = System.Windows.Forms.BorderStyle.FixedSingle;
this.DependsGraphTree.Location = new System.Drawing.Point(3, 96);
this.DependsGraphTree.Name = "DependsGraphTree";
this.DependsGraphTree.Size = new System.Drawing.Size(345, 489);

Changes

Now the relationships tree is 400 pixels tall, which allows it to fit in the available space since 96+400 < 502:

image

Fixes #2722.

@HebaruSan HebaruSan added Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Apr 13, 2019
@DasSkelett DasSkelett removed the Bug label Apr 13, 2019
@HebaruSan HebaruSan added the Bug label Apr 13, 2019
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of the list is visible again 👍

@HebaruSan HebaruSan merged commit d8819e3 into KSP-CKAN:master Apr 20, 2019
HebaruSan added a commit that referenced this pull request Apr 20, 2019
@HebaruSan HebaruSan deleted the fix/rel-height branch April 21, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Relationships' list can't be scrolled to the bottom
3 participants