Fix freeze on non CKAN files in cache folder #2743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users reported that CKAN freezes while trying to load the registry at startup.
Cause
This exception is thrown:
... which means that this block from #2563 tried to get a substring of a filename shorter than 8 characters:
CKAN/Core/Net/NetFileCache.cs
Lines 175 to 180 in 44d44ea
It appears that some users may have chosen a CKAN cache folder that is not exclusive to CKAN:
Changes
Now that block will ignore any filenames that don't start with 8 hex digits and a dash. This will both fix the problem with short filenames and exclude other files that were not created by CKAN even if they have long names.
Fixes #2711 (I think).