Put Dockerfile.netkan in build context #2840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#2838 added a build process to rebuild and push a Docker inflator container, but it failed:
https://travis-ci.org/KSP-CKAN/CKAN/jobs/569174846#L4638-L4642
Cause
Prior to docker/cli#886, the Dockerfile specified by the
-f
parameter had to be in the build directory for... some reason.That requirement was removed in Docker 18.03.0-ce. Travis has 17.09.0-ce. I have 18.09.7. So when I tested #2839 locally, it worked fine, then failed when pushed to master.
Changes
Now we copy
Dockerfile.netkan
into_build/docker/inflator
before building.If Travis ever upgrades to Docker 18.03.0-ce or later, we can revert this.