Allow totally incompatible modules in changeset #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, not working for me. Always throws the following error: even if I select another mod to install, f.e. So the selected mod isn't updated in the background (in the UI it is). The error is also thrown if I try to select a compatible mod via the checkbox in the modlist. |
|
Scratch that, problem was that ARSS was still selected in the versions tab... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #2821 we added the ability to select a specific version of a module to install in GUI rather than only installing the latest compatible. As part of this, incompatible versions were allowed as well.
However, you could only install an incompatible version if at least one other version of the module was compatible. Modules with no compatible versions (let's call them "totally incompatible") could be selected but would not show up in the changeset and could not be installed.
Cause
Totally incompatible modules were excluded in two ways, in line with the old assumptions about installability:
MainModList.ComputeUserChangeSetonly checked modules for whichIsInstallableis true (it's false for totally incompatible modules)GUIMod.GetRequestedChangesonly allowed installing a new module if the install checkbox was visible and checked (it's-for totally incompatible modules), and changing from one version to another only worked if the module was already installedChanges
MainModList.ComputeUserChangeSetchecks all modulesGUIMod.GetRequestedChangescan return an installation change even if the installation checkbox isn't available, as long asInstalledModandSelectedModaren't the same. As part of this, the old install/uninstall logic and the newer version-switching logic are unified to a single block.@xZise, if you'd like to try this change, here's a test build:
Fixes #2868.