Remove base64 encoded CKAN icon from resources #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2749 I found out that C# compilers don't de-duplicate resources and thus the base64 encoded CKAN icon used in the window decorations is contained multiple times in the final binary.
We reduced it to only one occurrence in the main
Resources.resxfile.However, we also added a reference to the
ckan.icofile, so the data nodeAppIconappeared twice inResources.resx. I think I forgot to remove it after some testing.One of those two should be removed.
Change
For the sake of reducing the size and line count of
Resources.resxand for consistency with other imported image files, I chose to delete the string representation of the icon.The .ico file reference works exactly as good as the base64 encoded icon included directly in the resource file in my testing.