Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to consoleui on MacOSX Catalina #2911

Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Nov 2, 2019

Problem

#2272 is now a live issue. MacOSX Catalina users who download CKAN.dmg and double click CKAN.app will just get errors.

Causes

Changes

Now the launch script attempts to check the OS version; if 10.15 or later, if the user gives no command line parameters, instead of launching the GUI, it will launch consoleui in Terminal.

I don't have a Mac (this work is based on StackExchange answers), so we will need to find a volunteer Mac user to test this.
Test build:

  • [link removed, download latest CKAN version]

@HebaruSan HebaruSan added Pull request macOS Issues specific for macOS ConsoleUI Issues affecting the interactive console UI Package: dmg Issues affecting macOS packaging labels Nov 2, 2019
@pfFredd
Copy link

pfFredd commented Nov 2, 2019

Installed the file linked to in the pull request and tested on Marcos 10.15. It loads without any issues, and installing mods work well.

@HebaruSan
Copy link
Member Author

You mean I got it right the first time? 😮
@pfFredd thanks for testing!!

@pfFredd
Copy link

pfFredd commented Nov 2, 2019

You mean I got it right the first time? 😮
@pfFredd thanks for testing!!

Seems so, well done @HebaruSan !

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we should be good to go.

HebaruSan added a commit that referenced this pull request Nov 2, 2019
@HebaruSan HebaruSan merged commit 9433b20 into KSP-CKAN:master Nov 2, 2019
@HebaruSan HebaruSan deleted the feature/macos-catalina-consoleui branch November 2, 2019 18:41
@ufukuyumaz
Copy link

hi , using previous versions cause "access to path denied" error on terminal. workaround for that is to delete CKAN folder in game path.

@DasSkelett
Copy link
Member

hi , using previous versions cause "access to path denied" error on terminal. workaround for that is to delete CKAN folder in game path.

This sound like a different problem, can you open a new issue for this?
https://github.com/KSP-CKAN/CKAN/issues/new?assignees=&labels=Bug&template=bug_report.md&title=%5BBug%5D+Briefly+summarize+your+issue+here

@Ruaphoc
Copy link

Ruaphoc commented Nov 18, 2019

Can we get a release, or even a pre-release? MacOS Catalina users are essentially dead in the water right now.

@HebaruSan
Copy link
Member Author

There's a download linked in the OP.

@acda3
Copy link

acda3 commented Nov 22, 2019

Verified that it worked fine (Catalina Beta 2). Thanks @HebaruSan ! Not sure if there was still any question, but I figured a second post verifying it would be useful. :)

@egavard
Copy link

egavard commented Nov 23, 2019

I don't know if this could help, but I tried to use the app contained in the zip in the first message.
I wasn't able to launch it without browsing directly into /Applications/CKAN.app/Contents/MacOS and typing mono "ckan.exe" consoleui in a shell.

Double clicking the app, or even use ./CKAN in the same folder didn't work at all.

@DasSkelett
Copy link
Member

DasSkelett commented Nov 23, 2019

I don't know if this could help, but I tried to use the app contained in the zip in the first message.
I wasn't able to launch it without browsing directly into /Applications/CKAN.app/Contents/MacOS and typing mono "ckan.exe" consoleui in a shell.

Double clicking the app, or even use ./CKAN in the same folder didn't work at all.

Which macOS version are you using? Please also give the version number (10.x).
Did you get any error messages?

@egavard
Copy link

egavard commented Nov 23, 2019 via email

@DasSkelett
Copy link
Member

Hmm, that should totally be catched by the script. What happens when you double-click the CKAN.app?
Also, you didn't accidentally run the old CKAN.app?

@egavard
Copy link

egavard commented Nov 23, 2019 via email

@HebaruSan
Copy link
Member Author

[link removed, download latest CKAN version]

Thanks for taking care of that, @DasSkelett ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ConsoleUI Issues affecting the interactive console UI macOS Issues specific for macOS Package: dmg Issues affecting macOS packaging Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants