Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owners of parent GitHub repos to authors #2922

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

HebaruSan
Copy link
Member

Motivation

The author property of a module can be a string or an array of strings. It's courteous to credit everyone who has maintained a mod over the years by listing them in an array.

It is somewhat common for a mod on GitHub to go out of maintenance and be adopted by a new maintainer on a fork of the original repo. When this happens, we switch the $kref to the new repo, and in order to preserve the full list of authors, we have to manually edit the author property to include them. It's better to rely on automatic data generation where possible, or at least to have the option.

Changes

Now if a repo is a fork-of-a-fork-of-a-fork-of..., we will traverse the parent repository chain all the way to the root and add all of the repository owners as co-authors. This will give a more accurate picture of who has contributed when a repo is forked.

Note that manual overrides of the author property still work the same, so this logic will not blow away any manually maintained author lists. To minimize the performance hit, we will not make any extra GitHub API calls when the author property is manually set in the netkan.

@HebaruSan HebaruSan added Enhancement Pull request Netkan Issues affecting the netkan data labels Nov 15, 2019
@DasSkelett
Copy link
Member

This is a cool idea!

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice(,) work(s)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Netkan Issues affecting the netkan data Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants