Request fewer GitHub releases and cache string URLs in Netkan #2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
The exact reason this happens is uncertain, but we suspect we're triggering GitHub's abuse prevention limits:
Changes
CachingHttpService.DownloadText
caches its results for 3 minutes, so any repeated requests for the same URL (e.g., if we inflate all of the KerboKatz modules in rapid succession) will only hit the server once. This will avoid the possibly abuse-y behavior of hitting the same URL over and over, and also probably speed up the Inflator a little bit (since memory is a lot faster than network).Fixes #2949 (hopefully!).