Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provides a list of identifiers in the schema #2952

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

HebaruSan
Copy link
Member

Problem

At one point in KSP-CKAN/NetKAN#7600, a confusing error happened because one module had this:

"provides": [ "AIES-Antenna_Patches" ],

And this conflict:

{ "name": "AIES-Antenna-Patches" }

AIES-Antenna-Patches is depended on by a dependency of this module, but since the provides had an underscore, it tried to pull in a conflicting module and got all confused.

Cause

The schema just has provides as a list of strings! But it has to be identifiers to be useful, so this is a missing guardrail that would have helped in this case.

Changes

Now the schema is updated to consider provides a list of identifiers. This will help with validating pull requests; if an element of provides has an invalid format, an error will be raised specifically about that.

@HebaruSan HebaruSan added Bug Something is not working as intended Pull request Schema Issues affecting the schema labels Dec 25, 2019
@techman83
Copy link
Member

Change LGTM. Thanks for your efforts!

@techman83 techman83 merged commit 3ab4bd7 into KSP-CKAN:master Jan 6, 2020
@HebaruSan HebaruSan deleted the fix/schema-provides branch January 6, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Schema Issues affecting the schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants