Make provides a list of identifiers in the schema #2952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At one point in KSP-CKAN/NetKAN#7600, a confusing error happened because one module had this:
And this conflict:
AIES-Antenna-Patches
is depended on by a dependency of this module, but since theprovides
had an underscore, it tried to pull in a conflicting module and got all confused.Cause
The schema just has
provides
as a list of strings! But it has to be identifiers to be useful, so this is a missing guardrail that would have helped in this case.Changes
Now the schema is updated to consider
provides
a list of identifiers. This will help with validating pull requests; if an element ofprovides
has an invalid format, an error will be raised specifically about that.