Label ordering buttons

[HebaruSan]

Motivation

The labels from #2936 have an implicit ordering that matters if a mod is included in multiple labels, but the user can't control this ordering except by editing a JSON file. Worse, this ordering is hidden in the Edit Labels window, which sorts each group of labels alphabetically by name.

Changes

Now the Edit Labels window shows the labels in their actual ordering rather than alphabetical.

Now when you edit a label, up and down buttons appear to the right of the label tree:

Clicking the up button moves the label earlier in the list, and clicking the down button moves it later.

Fixes #3395.

Side fixes

• The Japanese translation had a lot of duplicate references to resources, which are now removed
• Support replaced_by property #2671 added two image files that have never been used, GUI/Resources/arrow_forward.png and GUI/Resources/arrow_upward.png, which are now removed

[d-faure]

Right-clicking to edit labels is still leading to the same dialog with the selection invite., but selecting a label doesn't lead to anything and no editing is allowed. The Create button is working and allows appending a new label to the list.

[HebaruSan]

Right-clicking to edit labels is still leading to the same dialog with the selection invite., but selecting a label doesn't lead to anything and no editing is allowed. The Create button is working and allows appending a new label to the list.

Thanks for testing and reporting that, I have a guess as to what weird thing Windows is doing to cause that (not setting IsExpanded == True for nodes without children when we call ExpandAll), so I'll make some more changes in a bit that should address it...

[HebaruSan]

Thanks again @d-faure, the new test build is:

• https://github.com/KSP-CKAN/CKAN/suites/3388526713/artifacts/79920927

[d-faure]

Now, that's ok

[DasSkelett]

Should we move instance groups above the "Global" group, so the more specifics overwrite less specifics? I think that's what you'd typically expect in similar situations.

[HebaruSan]

Makes sense to me. Now the list model object sorts them that way on load (so the change will apply regardless of whether the user opens the editing form), and the editing UI maintains the ordering.

[DasSkelett]

Works very well now, nice feature!