Show dependencies of upgrading mods in change set #3560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The user should be told about this in the change set screen.
Cause
The change set screen has always only looked for dependencies for modules being installed, not upgraded.
I think the expectation was that all of the complicated stuff would happen for installs, while upgrades would be simple replacements of one version of a module with a newer version, even though the underlying relationship logic in Core can handle more complicated scenarios.
Changes
Now upgrades will be treated more like installs, in that any new dependencies they introduce will be displayed:
To make this work, we also need to fix
ComputeChangeSetFromModList
to use the upgraded version in calculating the change set. It was using the old version; luckily this only affects the change set screen and not the actual install, which is handled in Core.Fixes #3559.