Auto-size buttons in bottom panels

[HebaruSan]

Problems

• The bottom right button in Delete Directories is supposed to say "Delete Checked," since only the folders with checked checkboxes will be deleted, but on Windows it only says "Delete":
  

  CKAN/GUI/Controls/DeleteDirectories.resx

  Line 126 in 4f3da57

  <data name="DeleteButton.Text" xml:space="preserve"><value>Delete Checked</value></data>

  
  
  • This potentially can happen anywhere, especially if a translator picks a long string for a button
• The text of the progress bar screen's log text box is unreadable black-on-dark when I install things in Windows using the dark theme from Theme all buttons, checkboxes, groupboxes, and listboxes #3489, but readable light-on-dark for refreshing the mod list and repo updates.

Causes

• Most of our buttons use Anchor to position themselves and have hard coded sizes, and if those sizes aren't big enough to fit the text, it is truncated. Due to differences in fonts, we have enough space for "Delete Checked" on Linux bot not on Windows.
• The ForeColor we set is ignored because we aren't setting BackColor. The text color change happens because MainTabControl is disabled, which cascades into disabling the log text box.

Changes

• A new LeftRightRowPanel control hosts two groups of controls, one in .LeftControls and the other in .RightControls. These are passed through to a pair of FlowLayoutPanels, which themselves are hosted in the cells of a one-row TableLayoutPanel. Controls hosted in such a way will be positioned nicely while also being able to autosize themselves.
  • Most of the controls where we have a BottomButtonPanel now use LeftRightRowPanel for it, and the buttons contained therein have autosizing enabled in GrowOnly mode, so they will expand if needed to fit their contents but otherwise keep a nice friendly width for easy clicking:
    
    As a bonus, the buttons even wrap nicely when space is very limited:
    
  • The exception is the add repo popup, which has several non-Button controls on its BottomButtonPanel which cannot be easily split into left and right flow layout groups. This panel is now renamed BottomPanel to distinguish it from the ones that only contain Buttons.
  • The Depends/Recommends/etc. buttons in Export Modpack are radio buttons, which have an AutoSize property but not AutoSizeMode, so we have to choose between static sizes and making them smaller in some cases. For now I have left them with static sizes.
  • Since this layout logic is more robust than what we had before, the "Retry" and "Cancel" buttons on the progress bar tab are now hidden rather than disabled when they're not usable. And the update repo action is now properly treated as non-cancellable.
• Now we set the log text box's BackColor, which makes the text color render correctly in all cases. The disabling of MainTabControl is replaced with calls to tabController.SetTabLock, which is how we are supposed to disable the tab control.
• The splitter in mod info is now set to treat its top panel as fixed size, which should make it less likely to end up weird sizes.

[techman83]

Looks like a good enhancement 🎉