Log errors instead of PRs for OOO mods on GitHub #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
HebaruSan
force-pushed
the
fix/gh-pr-spam
branch
from
b91da88
to
a2dff98
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For many months now we have been getting hammered with bogus auto-epoch pull requests. Lately it has gotten worse, with occasional giant waves of many, many mods affected. Cleaning these up is very tedious and has by far eclipsed the usefulness of auto-epoching as a feature. #3571 didn't seem to help.
Cause
GitHub's API seems to be unreliable. We ask it for the list of releases for mods constantly, and something like 0.004% of the time it skips one or more releases (much more often if there's a "wave" in progress), and we get a bogus pull request because it looks like the versions went backwards.
Changes
Now we no longer auto-generate auto-epoch pull requests for mods on GitHub. All other mods can still benefit from this feature, but mods hosted on GitHub will now simply emit an error to the log. This will appear as an inflation error in Discord and the status page, and if it's a true out-of-order release, it will stay there for multiple passes and we can go look at it, otherwise it'll go away on its own in the next pass.
I'm planning to self-review this since I can just revert it if something goes wrong.