Fix missing mod info tab alerts #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
HebaruSan
force-pushed
the
fix/gui-incompat-alert
branch
from
d9aab2f
to
bb6a416
Compare
|
Really just submitted this for documentation; I'm going to self-review and merge, since it's small and should have been included in #3638... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
<!>alerts from #3271 are supposed to call user attention to the reason that an incompatible mod is incompatible; if the mod itself is incompatible, the Versions tab shows an alert, and if it's a problem with a relationship, the Relationships tab shows an alert:Problem
In the current build (not released yet), these alerts don't appear unless you click the Metadata tab.
Causes
UpdateModInfowas a hybrid of general and tab-specific updates that #3638 tried to split into separate pieces, and these alerts anded up associated with the metadata tab instead of the general update where they belong.Changes
Now the tab alerts are updated along with the header info, so they are always visible.