Inflation error for version_min and version_max
#3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Pull request
Netkan
DasSkelett
approved these changes
Sep 6, 2022
HebaruSan
changed the title
version_min and version_max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See KSP-CKAN/NetKAN#9321 and KSP-CKAN/NetKAN#9323, we inadvertently marked the latest version of Parallax as conflicting with it own dependencies by using
version_maxinstead ofmax_version, which made it impossible to install (but made it easier to install the previous version correctly).This happened previously in KSP-CKAN/NetKAN#8880 and KSP-CKAN/NetKAN#8881.
Causes
For game version requirements,
ksp_version_minandksp_version_maxare the correct forms.For mod version requirements,
min_versionandmax_versionare the correct forms. For metadata maintainers who routinely deal with game version requirements and much more rarely with mod version requirements, this is surprising and very hard to keep in mind. (I even confused them in the initial description of this PR.)Changes
Now if a relationship contains
version_minorversion_max, we raise an inflation error.