Authors as clickable filter links, combine search links w/ ctrl or shift #3672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continuing recent efforts to improve mod info (see #3670), and remembering my quest to find FruitGoose's mods (see KSP-CKAN/NetKAN#9351), influenced by the "sticky" checkbox on the Relationships tab (see #3638), I thought it would be nice to be able to click author names in mod info to set the filter, like the tab/label links. And if we're going to have both tag/label links and author links, that raises the possibility of wanting to use them together somehow.
Changes
[+]
button to add a filter moves up and down to align with the bottommost search, since you'd want to use it after populating that fieldMerging two searches produces their intersection (AND logic). I think this makes sense because the user's typical goal is to narrow down the list of mods more and more until the desired mod is found, and using OR logic would expand the list instead. Similarly, if you already have multiple OR searches and choose to merge a new filter into it, the new filter is merged into all of those existing ones, to make sure mods not matching the new filter drop off.
Since Ctrl- and Shift-clicking are not discoverable, a tooltip calls it out in each place where it's available.