Leave user requested dependencies in changeset #3728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reported by @vega-star on Discord. Many thanks for trying out the dev build and contributing feedback in enough detail to pinpoint this bug!
Cause
#3726 made it so that when you click to confirm a changeset, instead of recalculating the changeset from the mod grid as we did previously, it used the data from the same changeset object that the user just viewed and approved in the changeset tab. This allows us to use the changeset tab for changesets other than the one selected on the main mod list (such as reinstallation via the right click menu, which cannot otherwise be represented by the main mod list's checkboxes).
But if we just used the exact same changeset, then the auto-installed flag would never be set, because dependencies are included alongside user requested mods. We need to exclude auto-installed mods from the changeset so the core code can determine that they are in fact auto-installed. #3726 did this by excluding any mod that was a dependency of another mod in the changeset. Turns out that was wrong, because it's possible to pick several mods that are all mutual dependencies, which results in passing an empty changeset to the install flow.
Changes
Now instead of filtering out dependencies, we pick the user-requested mods, which is what #3726 should have done in the first place.