Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mod list saving options, add menu hotkeys #3771

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Feb 6, 2023

Problem

If a user wants to install their current mod list on another computer or share it with friends, they might click File → Save installed mod list... to generate a text file with their list of mods. However, there is no way to use this file to install that same mod list somewhere else. (It's mainly useful for posting your mod list to the forum.)

Thanks to Discord user SpaceTrash67 for bringing this up.

Cause

It's not easy to tell the difference between the menu options:

image

In the given use case, the user would have to try to guess and maybe experiment with these options to learn what they do.

Changes

Now the English versions of these menu options have a parenthetical clarification explaining whether the files they create can be re-imported, similar to what we did in #3400:

image

Other locales would have to be updated subsequently by their individual translators.

I also added hotkeys to the menus and made the existing hotkeys more consistent; i should really install rather than import, since the latter is much less commonly used.

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Feb 6, 2023
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what the purpose of the addition of all the & is. It would make it easier to review if a refactor is in a separate commit for clarity. But overall LGTM!

@HebaruSan HebaruSan merged commit 98f2836 into KSP-CKAN:master Feb 7, 2023
@HebaruSan HebaruSan deleted the fix/export-parentheticals branch February 7, 2023 02:49
@HebaruSan
Copy link
Member Author

The & in a resource XML file translates to & in the string, which acts as a prefix to set the hotkey for a menu, button, or label in WinForms.

@techman83
Copy link
Member

I thought so. Would be good to split the commit in future, but that makes sense 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants