Skip duplicate repo URLs during update #3786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A user reported this exception at start-up (partially translated from Chinese):
Cause
This callback could throw that exception if you had multiple repos configured to use the same URL:
CKAN/Core/Net/Repo.cs
Lines 56 to 58 in 8390a61
Doing that would not make sense, but apparently it happened anyway.
Changes
Now we filter out repo entries with duplicate URLs early in the update process, so we'll only download them once and the exception will not be thrown.
Also some strings in repo updating that I forgot to internationalize in #3645 are now internationalized.
Fixes #3761.