Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default GAME env var to KSP in Inflator Dockerfile, fix redeploy #3808

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Mar 11, 2023

Problem

If the $GAME environment variable isn't set, the Inflator won't start, as of #3797.

Also the docker-inflator Cake build target tries to redeploy the Inflator container, but that was renamed to InflatorKsp in KSP-CKAN/NetKAN-Infra#284. And the InflatorKsp2 container isn't touched at all.

Changes

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Pull request Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Mar 11, 2023
@HebaruSan HebaruSan changed the title Default GAME env var to KSP in Inflator Dockerfile Default GAME env var to KSP in Inflator Dockerfile, fix redeploy Mar 11, 2023
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@HebaruSan HebaruSan added the Build Issues affecting the build system label Mar 11, 2023
@HebaruSan HebaruSan merged commit efb7fc8 into KSP-CKAN:master Mar 11, 2023
@HebaruSan HebaruSan deleted the fix/docker-default-game branch March 11, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Build Issues affecting the build system Easy This is easy to fix Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants