Add download link to staging PRs #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
HebaruSan
force-pushed
the
feature/pr-download-link
branch
from
26f1ee9
to
6c8cfd9
Compare
|
Self-reviewing because this is small and so we can start benefitting from it in the next pull request from SpaceDock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dealing with KSP-CKAN/CKAN-meta#3183, KSP-CKAN/CKAN-meta#3184, KSP-CKAN/CKAN-meta#3185, KSP-CKAN/CKAN-meta#3186, and KSP-CKAN/CKAN-meta#3187 requires downloading the mod, but how to do this must be figured out by the PR reviewer (generally the answer is to click the spacedock or repository link and then click the download link on the host). This is inconvenient.
Changes
StagingLinksTransformernow executes afterDownloadAttributeTransformerandInstallSizeTransformer, which from reviewing Append resource links to staging PRs #3454 I think should be fineStagingLinksTransformeradds a row containingmetadata.Download