Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Causes
shouldQueue
wastrue
when it shouldn't have been, becausebytesLeft
wasn't0
when it should have been in another completed download. This value gets set whenever a progress update is raised, so either the last one was missing, or it had wrong numbers.Changes
bytesLeft
to0
in the completed download handler. This should prevent any problems with weird byte tracking.lock
block), to allow multiple concurrent ZIP validations to proceed without blocking one another.After these changes, I'm able to download and install RP-1 in Linux, where before it would reliably get stuck.