Fix Netkan swinfo transformer null list error #3869

HebaruSan · 2023-07-27T18:22:06Z

Problem

If a module has no depends relationships, then mod.depends is null here, and .Select doesn't work:

Lines 87 to 89 in 83b6e7d

 var moduleDeps = mod.depends.Select(r => (r as ModuleRelationshipDescriptor)?.name) 

 .Where(ident => ident != null) 

 .ToHashSet();

This problem was masked by all previous mods with swinfo.json files having a dependency on SpaceWarp.

Now if CkanModule.depends is null, we substitute the empty sequence.

Will self-review so that pull request can proceed.

Fix Netkan swinfo transformer null list error

c556475

HebaruSan added Bug Easy This is easy to fix Netkan Issues affecting the netkan data labels Jul 27, 2023

HebaruSan merged commit e78cf0e into KSP-CKAN:master Jul 27, 2023
10 checks passed

HebaruSan deleted the fix/swinfo-null-val-err branch July 27, 2023 18:25

	var moduleDeps = mod.depends.Select(r => (r as ModuleRelationshipDescriptor)?.name)
	.Where(ident => ident != null)
	.ToHashSet();